-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Task/wp 209 header, footer main menu #282
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds assets
- Created Main Menu layout similar to prod
- Moves user guide link to ProjectListing component
- Needs sticky header row
- Updates project listing and main menu to make table scroll - Updates Main Menu page with header and footer
sophia-massie
requested review from
nathanfranklin,
taoteg,
rstijerina and
shayanaijaz
November 22, 2024 19:41
…hazmapper into task/WP-209-Footer-Main-Menu
sophia-massie
changed the title
Task/wp 209 footer main menu
Task/wp 209 header, footer main menu
Nov 22, 2024
react/src/components/HazmapperHeader/HazmapperHeader.module.css
Outdated
Show resolved
Hide resolved
- Implements Header to Map pages - Used global header style height
Co-authored-by: Nathan Franklin <[email protected]>
Co-authored-by: Nathan Franklin <[email protected]>
Co-authored-by: Nathan Franklin <[email protected]>
…hazmapper into task/WP-209-Footer-Main-Menu
- Adds refetch to hook to get username after login - Changes auth slice to store the user to state in a way that gets picked up by userData
- Some adjustments for better container handling of listing
Addressed requested changes to
Ready for another review |
nathanfranklin
approved these changes
Dec 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 👍
I just have one comment about the link to taggit user guide.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
PR Status:
Related Jira tickets:
Summary of Changes:
Testing Steps:
UI Photos: