Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task/wp 209 header, footer main menu #282

Merged
merged 27 commits into from
Dec 3, 2024

Conversation

sophia-massie
Copy link
Contributor

@sophia-massie sophia-massie commented Nov 15, 2024

Overview:

PR Status:

  • Ready.
  • Work in Progress.
  • Hold.

Related Jira tickets:

Summary of Changes:

  • Adds image assets
  • Creates header component to be used by Map and Main Menu page
  • Updates project listing styles to make scroll table and have main menu children take up whole page

Testing Steps:

  1. Login to hazmapper and play with width/height.

UI Photos:

Screenshot 2024-12-03 at 11 09 12 AM

@sophia-massie sophia-massie marked this pull request as draft November 15, 2024 03:33
- Moves user guide link to ProjectListing component
- Updates project listing and main menu to make table scroll
- Updates Main Menu page with header and footer
@sophia-massie sophia-massie marked this pull request as ready for review November 22, 2024 19:41
@sophia-massie sophia-massie changed the title Task/wp 209 footer main menu Task/wp 209 header, footer main menu Nov 22, 2024
- Adds refetch to hook to get username after login
- Changes auth slice to store the user to state in a way that gets picked up by userData
- Some adjustments for better container handling of listing
@sophia-massie
Copy link
Contributor Author

Addressed requested changes to

  • error message not centered
  • regression in delete modal
  • factor out logo and user guide to main menu
  • factor out user hook to nav bar only
  • show login button when viewing public map, re-fetch user data on return

Ready for another review

Copy link
Collaborator

@nathanfranklin nathanfranklin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

I just have one comment about the link to taggit user guide.

react/src/pages/MainMenu/MainMenu.tsx Show resolved Hide resolved
@sophia-massie sophia-massie merged commit e879744 into main Dec 3, 2024
5 checks passed
@sophia-massie sophia-massie deleted the task/WP-209-Footer-Main-Menu branch December 3, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants